-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for broken nano-help #111
base: master
Are you sure you want to change the base?
Conversation
Thanks! Given the relative small size of the help, maybe it would be better to store it in a variable inside the source. What do you think? |
That's very reasonable and I should've done that. Pushed a fix, hope it's fine now. |
Thanks. I don't see the fix, did you push it? |
I removed the need for extra variable altogether, now it directly looks in the correct directory, without modifying the load-path at all. Hope that's acceptable! |
Sorry, I was saying to have the whole help string inside but maybe it's a bad idea in the end. Concerning your fix, I'm afraid it is a bit specific to the install method or is it the common place to search for files? |
It's a common place for straight users but you raise a valid point about this not working out for people who use other methods, since it's not a valid fix, I'll close the PR for now and think about incorporating other methods of installation in the future if possible. Apologies for the inconvenience. |
Sorry for the late answer and no need to apology. The issue is still valid since the help doesn't work as expected depending on the installation. This needs to be fixed. I'll reopen the issue to remember it needs to be fixed. |
Added a fix for
quick-help.org
not being found when using straight. Fixes the issue #110