Conversation
to avoid error below: > SyntaxError: Cannot use import statement outside a module
Rindrics
force-pushed
the
issue-3-enable-test
branch
from
a6136a3 to
8ac9365
Compare
bvlion
reviewed
Jun 12, 2024
bvlion
left a comment
bvlion
left a comment
There was a problem hiding this comment.
I have made one comment. Please check it.
.node-version
Outdated
| @@ -0,0 +1 @@ | |||
| 22 | |||
There was a problem hiding this comment.
nits: It seems advisable to pin the minor version as well to ensure compatibility and stability.
Suggested change
| 22 | |
| 22.3.0 |
Author
There was a problem hiding this comment.
thanks, fixing "minor" version makes sense.
but I'm planning to free "patch" version to apply security patch automatically.
Author
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3
src/printers/text.tsto confirm jest actually works