Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use case with RBAC to improve security #16

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

Rindrics
Copy link
Collaborator

close #6

Rindrics and others added 4 commits June 11, 2024 18:55
to prepare for feature addition:
  want to generate temporal credentials in `else` block
if `accessKey` and `secretKey` are not passed
@Rindrics Rindrics requested a review from a team June 11, 2024 09:57
@Rindrics Rindrics self-assigned this Jun 11, 2024
Copy link

@bvlion bvlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
I haven't tested the functionality, but I didn't find any issues in the code.

@@ -35,6 +35,7 @@ $ aws-cost --help
-k, --access-key [key] AWS access key
-s, --secret-key [key] AWS secret key
-r, --region [region] AWS region (default: us-east-1)
-a, --role-arn [arn] AWS role ARN to assume
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 👍

Base automatically changed from issue-14-lint-format to main June 13, 2024 05:33
@Rindrics
Copy link
Collaborator Author

thx!

@Rindrics Rindrics merged commit fcb59cc into main Jun 13, 2024
1 check passed
@Rindrics Rindrics deleted the issue-6-add-rbac branch June 13, 2024 05:33
This was referenced Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RBAC functionality
2 participants