Skip to content

Comments

Allow users to choose aggregation unit for Breakdown by service#22

Merged
Rindrics merged 9 commits intomainfrom
issue-9-aggregation-unit
Jun 14, 2024
Merged

Allow users to choose aggregation unit for Breakdown by service#22
Rindrics merged 9 commits intomainfrom
issue-9-aggregation-unit

Conversation

@Rindrics
Copy link

resolve #9

@Rindrics Rindrics requested a review from a team June 13, 2024 10:00
@Rindrics Rindrics self-assigned this Jun 13, 2024
Copy link

@bvlion bvlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!


run: build
node ./bin/index.js --profile "${AWS_PROFILE}" --access-key "${ACCESS_KEY}" --secret-key "${SECRET_KEY}" --role-arn "${ROLE_ARN}" --region "${AWS_REGION}" -S $(SLACK_TOKEN_AWS_COST_CLI) -C $(SLACK_CHANNEL_ID)
node ./bin/index.js --profile "${AWS_PROFILE}" --access-key "${ACCESS_KEY}" --secret-key "${SECRET_KEY}" --role-arn "${ROLE_ARN}" --region "${AWS_REGION}" -S "${SLACK_TOKEN_AWS_COST_CLI}" -C "${SLACK_CHANNEL_ID}" --breakdown-period "${BREAKDOWN_PERIOD}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rindrics Rindrics force-pushed the issue-9-aggregation-unit branch from 803691a to 87083ae Compare June 14, 2024 03:17
Base automatically changed from issue-8-fix-cost-aggregation-logic to main June 14, 2024 09:56
@Rindrics Rindrics merged commit fdff859 into main Jun 14, 2024
@Rindrics Rindrics deleted the issue-9-aggregation-unit branch June 14, 2024 09:57
This was referenced Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying the aggregation unit for 'Breakdown by service' in Slack notifications

2 participants