Resolve system ordering ambiguities #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Makes sense to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
ScheduleBuildSettings::ambiguity_detectionI noticed a few warnings for ambiguities between systems in this crate. This PR fixes them.The main conflict was on
TextUiWriterwhich requires mutable access to several text components.blink_cursor,show_hide_cursor,update_colorall update the cursor color so I declared a deterministic run order. In the other cases they set different properties of the text so I marked them as ambiguous. I also marked systems which use the text value or cursor timer as dependant on thekeyboardsystem which sets those components.