Be more forgiving before raising invalid spec file #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are cases where the name is "foo-variant" and there is only a "foo.spec", e.g. when the spec file is usign a flavor build in the Open Build Service. I think it is fine to not raise an error for those cases.
|
(still need to add a test case) |
|
I would rather this extra check be handled as separate policy. Not everyone wants to permit that, and OBS flavor build quirks aren't a good reason to allow it everywhere unconditionally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are cases where the name is "foo-variant" and there is only a "foo.spec", e.g. when the spec file is usign a flavor build in the Open Build Service. I think it is fine to not raise an error for those cases.