Automatically add Django RQ views to admin #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
added a commit
to terencehonles/django-rq
that referenced
this pull request
Dec 16, 2025
This change fixes the Django admin integration added in rq#747. As is, the integration adds the views, but they do not reverse properly without also including the URLs via `include("django_rq.urls")`. When using Django's `ModelAdmin`, the URLs registered will be in the "admin" namespace, but the templates were not updated to include a namespace so they fail to resolve. This change conditionally resolves with either the prefix `django_rq:` or `admin:django_rq_` depending on how the view is called (via the admin app or not) and the URLs are also registered with the corresponding prefix. In order to properly test this integration, the default URL conf has been updated to not include the django_rq URLS via `include`, and a separate `default_with_custom_mount_urls` URL conf is provided in order to test integrations using both `include` and the admin integration.
terencehonles
added a commit
to terencehonles/django-rq
that referenced
this pull request
Dec 16, 2025
This change fixes the Django admin integration added in rq#747. As is, the integration adds the views, but they do not reverse properly without also including the URLs via `include("django_rq.urls")`. When using Django's `ModelAdmin`, the URLs registered will be in the "admin" namespace, but the templates were not updated to include a namespace so they fail to resolve. This change conditionally resolves with either the prefix `django_rq:` or `admin:django_rq_` depending on how the view is called (via the admin app or not) and the URLs are also registered with the corresponding prefix. In order to properly test this integration, the default URL conf has been updated to not include the django_rq URLS via `include`, and a separate `default_with_custom_mount_urls` URL conf is provided in order to test integrations using both `include` and the admin integration.
terencehonles
added a commit
to terencehonles/django-rq
that referenced
this pull request
Dec 16, 2025
This change fixes the Django admin integration added in rq#747. As is, the integration adds the views, but they do not reverse properly without also including the URLs via `include("django_rq.urls")`. When using Django's `ModelAdmin`, the URLs registered will be in the "admin" namespace, but the templates were not updated to include a namespace so they fail to resolve. This change conditionally resolves with either the prefix `django_rq:` or `admin:django_rq_` depending on how the view is called (via the admin app or not) and the URLs are also registered with the corresponding prefix. In order to properly test this integration, the default URL conf has been updated to not include the django_rq URLS via `include`, and a separate `default_with_custom_mount_urls` URL conf is provided in order to test integrations using both `include` and the admin integration.
selwin
pushed a commit
that referenced
this pull request
Dec 23, 2025
This change fixes the Django admin integration added in #747. As is, the integration adds the views, but they do not reverse properly without also including the URLs via `include("django_rq.urls")`. When using Django's `ModelAdmin`, the URLs registered will be in the "admin" namespace, but the templates were not updated to include a namespace so they fail to resolve. This change conditionally resolves with either the prefix `django_rq:` or `admin:django_rq_` depending on how the view is called (via the admin app or not) and the URLs are also registered with the corresponding prefix. In order to properly test this integration, the default URL conf has been updated to not include the django_rq URLS via `include`, and a separate `default_with_custom_mount_urls` URL conf is provided in order to test integrations using both `include` and the admin integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.