Skip to content

fix: freezed_missing_mixin on private types due to leading underscore #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+225 −1
Open

fix: freezed_missing_mixin on private types due to leading underscore #1279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/freezed_lint/example/lib/mixin_name.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import 'package:freezed_annotation/freezed_annotation.dart';

part 'mixin_name.freezed.dart';

@freezed
class _FooModel with _$FooModel {
const factory _FooModel() = __FooModel;
}
214 changes: 214 additions & 0 deletions packages/freezed_lint/example/lib/mixin_name.freezed.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/freezed_lint/lib/src/missing_mixin.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ class MissingMixin extends DartLintRule {
final annotation = freezedAnnotationChecker.hasAnnotationOfExact(element);
if (!annotation) return;

final name = '_\$${element.name}';
final name = element.name.startsWith('_')
? '_\$${element.name.substring(1)}'
: '_\$${element.name}';
final withClause = node.withClause;
if (withClause == null) {
reporter.atElement(element, _code, arguments: [name]);
Expand Down