Fix EqualUnmodifiableListView equality comparison (Fixes #1308)

packages/freezed/lib/src/templates/abstract_template.dart

@@ -46,7 +46,7 @@ mixin _\$${data.name.public}${data.genericsDefinitionTemplate}$interfaces {
 
 $abstractProperties
 ${copyWith?.copyWithGetter(needsCast: true) ?? ''}
-${methods(data, globalData, properties: commonProperties, name: data.name, escapedName: data.escapedName, source: Source.mixin)}
+${methods(data, globalData, properties: commonProperties, name: data.name, escapedName: data.escapedName, source: Source.mixin, isConst: false)}
 }
 
 ${copyWith?.commonInterface ?? ''}

packages/freezed/lib/src/templates/concrete_template.dart

@@ -50,7 +50,7 @@ class ${constructor.redirectedName}${data.genericsDefinitionTemplate} $_concrete
 $_properties
 
 ${copyWith?.copyWithGetter(needsCast: false) ?? ''}
-${methods(data, globalData, properties: constructor.properties, name: constructor.redirectedName, escapedName: constructor.escapedName, source: Source.syntheticClass)}
+${methods(data, globalData, properties: constructor.properties, name: constructor.redirectedName, escapedName: constructor.escapedName, source: Source.syntheticClass, isConst: constructor.isConst)}
 }
 
 ${copyWith?.interface ?? ''}
@@ -325,12 +325,13 @@ String methods(
   required String name,
   required String escapedName,
   required Source source,
+  required bool isConst,
 }) {
   return '''
 ${toJson(data, name: name, source: source)}
 ${debugFillProperties(data, globalData, properties, escapedClassName: escapedName)}
 ${operatorEqualMethod(data, properties, className: name, source: source)}
-${hashCodeMethod(data, properties, source: source)}
+${hashCodeMethod(data, properties, source: source, isConst: isConst)}
 ${toStringMethod(data, globalData, escapedClassName: escapedName, properties: properties)}
 ''';
 }
@@ -467,6 +468,7 @@ String hashCodeMethod(
   Class data,
   List<Property> properties, {
   required Source source,
+  required bool isConst,
 }) {
   if (!data.options.equal) return '';
 
@@ -491,25 +493,26 @@ String hashCodeMethod(
         property.name,
   ];
 
-  if (hashedProperties.length == 1) {
-    return '''
-$jsonKey
-@override
-int get hashCode => ${hashedProperties.first}.hashCode;
-''';
-  }
-  if (hashedProperties.length >= 20) {
+  final hashCodeExpression = hashedProperties.length == 1
+      ? '${hashedProperties.first}.hashCode'
+      : hashedProperties.length >= 20
+          ? 'Object.hashAll([${hashedProperties.join(',')}])'
+          : 'Object.hash(${hashedProperties.join(',')})';
+
+  if (isConst || source == Source.mixin) {
     return '''
 $jsonKey
 @override
-int get hashCode => Object.hashAll([${hashedProperties.join(',')}]);
+int get hashCode => $hashCodeExpression;
 ''';
   }
 
   return '''
 $jsonKey
+int? _cachedHashCode;
+
 @override
-int get hashCode => Object.hash(${hashedProperties.join(',')});
+int get hashCode => _cachedHashCode ??= $hashCodeExpression;
 ''';
 }
 

packages/freezed_annotation/lib/freezed_annotation.dart

@@ -18,11 +18,12 @@ class EqualUnmodifiableListView<T> extends UnmodifiableListView<T> {
   bool operator ==(Object other) {
     return other is EqualUnmodifiableListView<T> &&
         other.runtimeType == runtimeType &&
-        other._source == _source;
+        const DeepCollectionEquality().equals(other._source, _source);
   }
 
   @override
-  int get hashCode => Object.hash(runtimeType, _source);
+  int get hashCode =>
+      Object.hash(runtimeType, const DeepCollectionEquality().hash(_source));
 }
 
 /// An [UnmodifiableSetView] which overrides ==
@@ -36,11 +37,12 @@ class EqualUnmodifiableSetView<T> extends UnmodifiableSetView<T> {
   bool operator ==(Object other) {
     return other is EqualUnmodifiableSetView<T> &&
         other.runtimeType == runtimeType &&
-        other._source == _source;
+        const DeepCollectionEquality().equals(other._source, _source);
   }
 
   @override
-  int get hashCode => Object.hash(runtimeType, _source);
+  int get hashCode =>
+      Object.hash(runtimeType, const DeepCollectionEquality().hash(_source));
 }
 
 /// An [UnmodifiableMapView] which overrides ==
@@ -55,11 +57,12 @@ class EqualUnmodifiableMapView<Key, Value>
   bool operator ==(Object other) {
     return other is EqualUnmodifiableMapView<Key, Value> &&
         other.runtimeType == runtimeType &&
-        other._source == _source;
+        const DeepCollectionEquality().equals(other._source, _source);
   }
 
   @override
-  int get hashCode => Object.hash(runtimeType, _source);
+  int get hashCode =>
+      Object.hash(runtimeType, const DeepCollectionEquality().hash(_source));
 }
 
 /// Options for enabling/disabling specific `Union.map` features;