Skip to content

Fix EqualUnmodifiableListView equality to use content-based comparison #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix EqualUnmodifiableListView equality to use content-based comparison #1311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/freezed_annotation/lib/freezed_annotation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ class EqualUnmodifiableListView<T> extends UnmodifiableListView<T> {
bool operator ==(Object other) {
return other is EqualUnmodifiableListView<T> &&
other.runtimeType == runtimeType &&
other._source == _source;
const DeepCollectionEquality().equals(other._source, _source);
}

@override
int get hashCode => Object.hash(runtimeType, _source);
int get hashCode => Object.hash(runtimeType, const DeepCollectionEquality().hash(_source));
}

/// An [UnmodifiableSetView] which overrides ==
Expand All @@ -36,11 +36,11 @@ class EqualUnmodifiableSetView<T> extends UnmodifiableSetView<T> {
bool operator ==(Object other) {
return other is EqualUnmodifiableSetView<T> &&
other.runtimeType == runtimeType &&
other._source == _source;
const DeepCollectionEquality().equals(other._source, _source);
}

@override
int get hashCode => Object.hash(runtimeType, _source);
int get hashCode => Object.hash(runtimeType, const DeepCollectionEquality().hash(_source));
}

/// An [UnmodifiableMapView] which overrides ==
Expand All @@ -55,11 +55,11 @@ class EqualUnmodifiableMapView<Key, Value>
bool operator ==(Object other) {
return other is EqualUnmodifiableMapView<Key, Value> &&
other.runtimeType == runtimeType &&
other._source == _source;
const DeepCollectionEquality().equals(other._source, _source);
}

@override
int get hashCode => Object.hash(runtimeType, _source);
int get hashCode => Object.hash(runtimeType, const DeepCollectionEquality().hash(_source));
}

/// Options for enabling/disabling specific `Union.map` features;
Expand Down
Loading