-
-
Notifications
You must be signed in to change notification settings - Fork 301
Add build_config triggers #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add build_config triggers #1330
Conversation
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-01-07T20:51:22.701ZApplied to files:
📚 Learning: 2025-01-07T20:51:22.701ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/freezed/build.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: freezed (packages/freezed, stable, get)
🔇 Additional comments (2)
packages/freezed/build.yaml (2)
15-15: Confirm the optimization change doesn't impact existing test coverage or CI workflows.This change optimizes build speed by restricting the freezed builder to run only when the specified annotations are present. While this is intentional, ensure that:
- Existing CI/CD pipelines don't rely on unconditional builder execution
- Test fixtures or generated code paths that depend on the builder running are covered by the trigger annotations
- Documentation or migration notes are updated if this is a significant change for users
Also applies to: 30-34
30-34: The review comment is incorrect—no triggers section is needed in build.yaml.The freezed builder uses
GeneratorForAnnotation<Freezed>from the source_gen package, which automatically discovers and processes classes annotated with theFreezedtype. The three public annotations (@Freezed,@freezed,@unfreezed) are all instances of the sameFreezedclass defined in the freezed_annotation package, and source_gen handles their detection without requiring explicit trigger configuration in build.yaml. The current build.yaml is correctly configured and does not need a triggers section.Likely an incorrect or invalid review comment.
|
I checked the tests, and they seem to be broken on master as well. No new tests have failed with this change, so it should be fine. |
With build_config 1.2.0, a new mechanism has been added to optimize build speed - the triggers. See https://pub.dev/packages/build_config#triggers for an explanation of this feature.
This PR adds the corresponding configration to enable triggers for the freezed builder.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.