Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

In-memory reading from tar archives instead of extract to temp folder #466

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

Scondo
Copy link
Contributor

@Scondo Scondo commented Jul 26, 2021

Get rid of work with filesystem in fs-unrelated tests.

No more problems like #465 lead to tests failure.

@koivunej
Copy link
Collaborator

koivunej commented Aug 2, 2021

This does seem like a very obvious fix, thanks for this! I don't really know why I failed to consider an inmemory version here initially. The build is a bit broken but we'll look into getting it fixed this week, so I'll leave this pending until fixed.

@koivunej
Copy link
Collaborator

koivunej commented Aug 2, 2021

Not approving for workflow run because this uses an older version of workflow, which was fixed today (#469, #468). Thanks for small PR, lets see if we can just let bors handle this.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 2, 2021

Build succeeded:

@bors bors bot merged commit b63eb14 into rs-ipfs:master Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants