-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M0022 cancellation #408
M0022 cancellation #408
Conversation
89002b5
to
477ac30
Compare
Hi, i'm trying to test this with the last version of Core and S.X.L. I updated the "local" validator in my PC with your files but i still give this error: Site::Traffic Light Controller Signal Priority state goes through received, activated, completed /spec/site/tlc/signal_priority_spec.rb:135:in Why? |
I also make the rebuild of gems, it waits always for complete the priority but a cancellation request doesn't arrive. You may understand where is the issue from the logs above? |
It looks like you're not using the latest validator.
If you have local modifications you would have to either discard them or rebase on main. You can run this to check the commit you're on:
|
Hi, we are trying to use docker. We downloaded the latest version of rsmp_validator REPOSITORY TAG IMAGE ID CREATED SIZE with command -> give us this error. spec/site: 1: [: bundle,: unexpected operator Before with the previous validator it was working. I only updated the image. Do you know for what reason give us this error ? |
Ok I see, you're running via Docker. The Docker images is build automatically, latest is from 5 days ago: I get the same error when I try to run the validator using that image. However it works when I build the Docker images locally and run it. Not sure why this is happening, but perhaps it's related to the fact that the latest version of the validator updated the .tool-versions file to use Ruby 3.3.2. I'll look into it. If you're in a hurry you can install the validator locally as described at https://rsmp-nordic.github.io/rsmp_validator/install/, or optionally build and run the Docker image locally from the Dockerfile in the repo. |
See #414, you can add ":main" to the docker image name to make it work. |
Thank you! KR, |
When running tests against the Cartesio, this config is used: It includes a list of signal groups. This should match what's configured on the device. The M0022 tests use the first of these configured signal groups: signal_group_id = Validator.get_config('components','signal_group').keys.first |
If you have additional questions please open a new issue. |
Fixes #400.
Signal Priority Rquests tests updated:
For the normal flow, the test will cancel the requests, and it should then become completed.
Added a new tests, where the request is not cancelled, it should then become stale after a while.