update clang-format-review workflow #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsore
added a commit
that referenced
this pull request
Oct 20, 2024
update clang-format-review workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow was not working properly before. This development branch solves two things:
It actually makes the clang-tidy analysis work. I don't know exactly what went wrong before, but I had trouble getting the cmake_command option for ZedThree/clang-tidy-review working. So now we instead use lukka/run-cmake to actually generate the compile_commands.json file, and then use ZedThree/clang-tidy-review strictly for running clang-tidy and generating reviews.
The act of analysing the code and posting a review has been split up into two separate workflows. According to the documentation of ZedThree/clang-tidy-review, this should work better for public repositories where users might create pull requests from their own forks of the repo.