Add reset() method to ValueContainer #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
rsore
added a commit
that referenced
this pull request
Oct 20, 2024
Add reset() method to ValueContainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this development branch I have added a utility function in the
ValueContainerclass,reset(). It simply resets the internal tuple to contain allstd::nullopt.This utility function does not yet serve any purpose for the
Parserat this time, but will likely be necessary later. I want the parser itself to be re-usable to parse several sets of arguments, and instead of creating a newValueContainereach time, I would prefer to just reset theValueContainer.How Has This Been Tested?
I have implemented unit tests for the already existing
ValueContainerfunctions, as well as for the newreset()function.