Skip to content

Commit

Permalink
Always evaluate renderDT()'s ... in the parent.frame() (#1130)
Browse files Browse the repository at this point in the history
 Close #1129. Always evaluate renderDT()'s ... in the parent.frame()
  • Loading branch information
cpsievert authored Mar 14, 2024
1 parent b256b83 commit 63517cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

- Added `outputArgs` parameter to `renderDataTable`, to allow width and height to be set when using interactive R Markdown documents.

- Fixed a bug in `renderDT()`'s evaluation of `...` arguments when `quoted = TRUE` (#1130).

# CHANGES IN DT VERSION 0.32

- Fixed a bug that caused the column used for grouping with the RowGroup extension to change when relocated by the ColReorder extension (thanks, @isthisthat, @mikmart, #1109).
Expand Down
2 changes: 1 addition & 1 deletion R/shiny.R
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ renderDataTable = function(
outputInfoEnv[["session"]] = NULL

exprFunc = shiny::exprToFunction(expr, env, quoted = TRUE)
argFunc = shiny::exprToFunction(list(..., server = server), env, quoted = FALSE)
argFunc = shiny::exprToFunction(list(..., server = server), parent.frame(), quoted = FALSE)
widgetFunc = function() {
opts = options(DT.datatable.shiny = TRUE); on.exit(options(opts), add = TRUE)
instance = exprFunc()
Expand Down

0 comments on commit 63517cb

Please sign in to comment.