Ignore invalid criteria in SearchBuilder server-side processing#1114
Merged
yihui merged 2 commits intorstudio:mainfrom Jan 21, 2024
Merged
Ignore invalid criteria in SearchBuilder server-side processing#1114yihui merged 2 commits intorstudio:mainfrom
yihui merged 2 commits intorstudio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1113.
Sometimes the client will send SearchBuilder queries that contain incomplete or invalid search criteria. For example, when the user changes the
datathat an existing criteria applies to, a search will be sent to the server with theconditioncomponent missing. In client-side processing, such invalid criteria are ignored.This PR aligns server-side processing with the client-side implementation, by returning
NULLto signal that a condition is invalid and should be ignored or that the search contains no valid criteria.