Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'copy.mode = FALSE' to all calls of file.copy outside tools directory #1183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

savyajha
Copy link

@savyajha savyajha commented Feb 9, 2025

Fix for #1154.

I am facing the same problem and I saw that the issue was reported earlier.

Pull Request

Before you submit a pull request, please ensure you've completed the following checklist

  • Ensure there is an already open and relevant GitHub issue describing the problem in detail and you've already received some indication from the maintainers that they are welcome to a contribution to fix the problem. This helps us to prevent wasting anyone's time.

  • Add unit tests in the tests/testthat directory.

  • This project uses roxygen2 for documentation. If you've made changes to documentation, run devtools::document().

  • Run devtools::check() (or, equivalently, click on Build->Check Package in the RStudio IDE) to make sure your change did not add any messages, warnings, or errors.

    • Note there is a decent chance that some tests were already failing before your changes. Just make sure you haven't introduced any new ones.
  • Ensure your code changes follow the style outlined in http://r-pkgs.had.co.nz/style.html

  • Add an entry to NEWS.md concisely describing what you changed.

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2025

CLA assistant check
All committers have signed the CLA.

@gadenbuie
Copy link
Member

Thanks for the PR @savyajha. It'd be helpful if you could join the conversation in #1154 to provide additional details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants