Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vignettes #102

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Vignettes #102

wants to merge 3 commits into from

Conversation

chendaniely
Copy link
Member

Resubmitting #78 but with just the .Rmd documents since there was a conflict in that PR

@chendaniely chendaniely mentioned this pull request Mar 24, 2020
Closed
2 tasks
@chendaniely
Copy link
Member Author

Seem like the CI is failing because of Unittests. not because of the vignettes

schloerke
schloerke reviewed Mar 27, 2020
View reviewed changes
vignettes/z-developers_guide.Rmd Outdated

# In `learnr` documents

# Standalone
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file complete? Should it be included for now?

schloerke
schloerke reviewed Mar 27, 2020
View reviewed changes
vignettes/a-000-introduction_to_gradethis.Rmd Outdated
and pass in various `pass_if` and `fail_if` conditions.
The **first** condition that matches will return the corresponding feedback, i.e.,
if a `pass_if` case matches then the student's solution passed,
if a `fail_if case matches then the student's solution failed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing `

@schloerke
Copy link
Collaborator

A warning is being created due to the vigs.

* checking files in ‘vignettes’ ... WARNING
Files in the 'vignettes' directory but no files in 'inst/doc':
  ‘a-000-introduction_to_gradethis.Rmd’, ‘a-010-using_equal.Rmd’,
    ‘z-developers_guide.Rmd’
Package has no Sweave vignette sources and no VignetteBuilder field.

Call usethis::use_vignette("tmp") and delete the tmp vignette it creates. We're after the other side effects of the function.

@schloerke schloerke self-requested a review March 27, 2020 21:12
schloerke
schloerke requested changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@chendaniely chendaniely requested a review from schloerke May 27, 2020 20:09
@chendaniely
Copy link
Member Author

@gadenbuie I heard that you are remaking these since the interface has changed drastically from the initial PR. So this PR can probably be closed.

Is there any vignette idea you would like written in its place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke Awaiting requested review from schloerke

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chendaniely @schloerke