Merged
Conversation
…e directories. This commit also converts from using job-json-overrides in the auto-scaling example to Launcher templates.
tnederlof
approved these changes
Dec 19, 2024
Contributor
tnederlof
left a comment
tnederlof
left a comment
There was a problem hiding this comment.
Looks good to me! When I did a big revamp of the examples a few months ago I didn't touch the auto-scaling folder so good to update. It would be ideal to work into the doc site https://docs.posit.co/helm/examples/workbench/ but its not under workbench so maybe that's another project to move it under the workbench folder and add a .qmd like the other.
jforest
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new example that creates user home directories with 700 permissions, which is a common customer request.
It also updates the older auto-scaling example to use templates for that annotation, rather than job-json-overrides