New "create a new board" vignette #751
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
commented
Jun 14, 2023
Comment on lines
+195
to
+197
| - `test_api_basic(board)` | ||
| - `test_api_versioning(board)` | ||
| - `test_api_meta(board)` |
Member
Author
There was a problem hiding this comment.
These are unexported too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #737 as well as #481
I got a start on this draft while working on #749 and used the Google Drive board as the example. It's a pretty good example, mostly because the googledrive R package is so nice.
One thing this vignette highlights is that a lot of functions needed to create these methods are internal, like
version_setup(),check_pin_exists(), and so forth, are all unexported. Should we export them? Or show them being used likepins:::check_pin_exists()in this vignette?