Fix openSUSE 15.4 image build; begin replacing fpm with nFPM #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SUSE 15.4 image build failed as soon as I merged #134 due to a Ruby gem dependency issue with fpm, the DEB/RPM packaging tool:
https://github.com/rstudio/r-builds/runs/7924309239?check_suite_focus=true
The public_suffix gem depends on Ruby >= 2.6 which openSUSE doesn't provide, so we would've had to pin fpm to an older version or wait for a fix in fpm.
Instead, I've replaced fpm with a different tool called nFPM, which @atheriel recommended a while back:
nFPM is a Go-based alternative to fpm that should be more reliable, has better support for code signing (#7), and still has all the features we need from fpm. fpm has had so many Ruby gem dependency issues over the years that have made it a pain to maintain:
#86
#110 (comment)
#83 (comment)
#64 (comment)
The migration was pretty straightforward, and there were just a few differences in the configs to account for:
Epoch: 0
andDistribution: (none)
fields to the RPMs, unlike fpm, which I couldn't figure out how to remove. I don't think this is a big deal.License
/Vendor
fields from DEBsMaintainer
formatting toRStudio, PBC <https://github.com/rstudio/r-builds>
, although lintian still says this is invalid (because it's not an email perhaps)Section
touniverse/math
on Ubuntu andgnu-r
on Debian to match ther-base
packagesI only replaced fpm for the newest platforms here to get SUSE 15.4 fixed asap, and will migrate the other platforms later.
Here's what the RPM and DEB fields look like, before and after.
RPMs:
DEBs: