Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm making this PR for discussion. Currently we use Babel so that we can generate ES5 code. I found that the generated ES5 code makes it harder to debug the code (even when using
options(shiny.minified=F)) because async code gets transformed into something quite different from the original.Modern browsers don't need to be stuck with ES5 anymore, so in this PR I removed Babel and changed the complication target to ES2020.
The one significant issue I can see with this change is that it will probably cause shiny to not work on PhantomJS, which will cause shinytest to stop working. (That's why this is a draft PR.)