Skip to content

Use bs-danger instead of bs-danger-text-emphasis for text color on error messages #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2024
Merged

Use bs-danger instead of bs-danger-text-emphasis for text color on error messages #4001

merged 1 commit into from
Mar 20, 2024

Conversation

cpsievert
Copy link
Collaborator

Closes #4000

@cpsievert cpsievert requested a review from gadenbuie March 20, 2024 17:00
@cpsievert cpsievert added this to the 1.9 milestone Mar 20, 2024
gadenbuie
gadenbuie approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpsievert cpsievert merged commit f0059b7 into main Mar 20, 2024
@cpsievert cpsievert deleted the bs5-error-text-color branch March 20, 2024 17:18
gadenbuie added a commit to posit-dev/py-shiny that referenced this pull request Mar 28, 2024
@gadenbuie
docs(changelog): rstudio/shiny#4001
41aa9ef
@gadenbuie gadenbuie mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

Error message text color is too subtle with Bootstrap 5
2 participants
@cpsievert @gadenbuie