Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple shortcodes cannot work on the same page #1979

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Utsav-Ladani
Copy link
Collaborator

Multiple shortcodes cannot work on the same page

  • rtmedia_gallery shortcode is not working correctly when adding it more than once.
  • Reason behind this is the pagination is designed that way.
  • Tried to fix this and was able to with backbone.js, but it works only for the Load More type pagination.
  • 1,2,3...6 numerical pagination is based on the URL. All data is loaded using the URL /pg/2/.
  • In this case, two different shortcodes with different pages will not work.
  • So this PR adds restriction and prevents the shortcode from generating output if It is used more than once.

@kjnanda
Copy link
Contributor

kjnanda commented Jul 25, 2023

@Pradeep1308 Can you please share the visual of the issue and fix you added? This will help us to replicate and cross check.

CC @pavanpatil1

Base automatically changed from pre-release to develop November 16, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants