Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-246/GH-247: Issue with transcoding the previously uploaded audio files [Master] #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GH-246/GH-247: Issue with transcoding the previously uploaded audio files [Master] #266

wants to merge 1 commit into from

Conversation

Pathan-Amaankhan
Copy link
Member

@Pathan-Amaankhan Pathan-Amaankhan commented Mar 9, 2023 •
edited
Loading

Description

  • This PR updates conditional check for mp3 files.

Requirement

  • The default post_mime_type for .m4a files is audio/mpeg(The same is for .mp3 files), so our condition was failing.

Screenshot 2023-03-09 at 6 48 52 PM

  • Whenever we transcode any audio file, file is converted to mp3 & attachment is updated in wp_postmeta but in wp_posts, we are still having post_mime_type of the old media file.

Screenshot 2023-03-16 at 3 58 38 PM

Screenshot 2023-03-16 at 4 00 33 PM

Fixes/Covers

@Pathan-Amaankhan Pathan-Amaankhan marked this pull request as ready for review March 10, 2023 09:45
@Pathan-Amaankhan Pathan-Amaankhan changed the title GH-246: Issue with transcoding the previously uploaded .m4a files [Master] GH-246/GH-247: Issue with transcoding the previously uploaded .m4a/.mp3 files [Master] Mar 16, 2023
@Pathan-Amaankhan Pathan-Amaankhan changed the title GH-246/GH-247: Issue with transcoding the previously uploaded .m4a/.mp3 files [Master] GH-246/GH-247: Issue with transcoding the previously uploaded audio files [Master] Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekfdd abhishekfdd Awaiting requested review from abhishekfdd

@dishitpala dishitpala Awaiting requested review from dishitpala

@gagan0123 gagan0123 Awaiting requested review from gagan0123

@pradeep910 pradeep910 Awaiting requested review from pradeep910

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Pathan-Amaankhan