fix edition 2024 unsafe link section #1055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfoHT
reviewed
Apr 16, 2025
Comment on lines
10
to
+12
| - Adapt `slic` backends to new version with `mecall` | ||
| - Allow software tasks to be diverging (return `!`) and give them `'static` context. | ||
| - Fix: supoort edition 2024 `unsafe(link_section)` attribute |
There was a problem hiding this comment.
Suggested change
| - Adapt `slic` backends to new version with `mecall` | |
| - Allow software tasks to be diverging (return `!`) and give them `'static` context. | |
| - Fix: supoort edition 2024 `unsafe(link_section)` attribute | |
| - Fix: supoort edition 2024 `unsafe(link_section)` attribute | |
| - Adapt `slic` backends to new version with `mecall` | |
| - Allow software tasks to be diverging (return `!`) and give them `'static` context. |
|
Really nice you spotted it and got it sorted! Thank you 🚀 Would be amazing if this could be caught in the future with some UI test or similar, something you could look into perhaps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In edition 2024, we must use
#[unsafe(link_section = ...)]instead of#[link_section = ...]. Butrtic_macrosis only checking for#[link_section = ...].link_sectionis used asunsafe(link_section = ...)