Add multi-line comment support to parser #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakulpathak3
force-pushed
the
multiline-comment-grammar
branch
2 times, most recently
from
1fa3f11 to
36c2c4c
Compare
Copied this straight from Pest itself so must be right 😅 https://github.com/pest-parser/pest/pull/332/files Tested against ``` /* 1-line multiline comment */ /* N-line multiline comment */ /* // Line comment inside multiline /* (Multiline inside) multiline */ */ ``` Testing steps - * `cargo build` * `make run` * `scripts/local-run` with above inputs Fixes rtyler#57
nakulpathak3
force-pushed
the
multiline-comment-grammar
branch
from
36c2c4c to
86b7f7d
Compare
rtyler
approved these changes
Dec 12, 2020
There was a problem hiding this comment.
Haha, I had recently found that code and copied it too, but only in my Jenkins Declarative Parser experiment.
Thanks 😸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied this straight from Pest itself so must be right 😅
https://github.com/pest-parser/pest/pull/332/files
Tested against
Testing steps -
cargo buildmake runscripts/local-runwith above inputsFixes #57