Skip to content

Commit

Permalink
🔧 Cop Rake/MethodDefinitionInTask is 66% broken
Browse files Browse the repository at this point in the history
  • Loading branch information
pboling committed Nov 9, 2023
1 parent 948107c commit 26ba5f8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
### Removed

## [1.0.10] 2023-11-09
### Changed
- Disable `Rake/MethodDefinitionInTask` Cop
- Cop is 66% incorrect, and hasn't been fixed in 2+ years.
- See: https://github.com/rubocop/rubocop-rake/issues/42

## [1.0.9] 2023-09-20
### Fixed
- Gemspec/DevelopmentDependencies changed to gemspec
Expand Down
7 changes: 6 additions & 1 deletion config/internal/base.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Alphabetizing lists enforces minimal churn in git history
# Alphabetizing lists enforces minimal churn in git history post-correction
Bundler/OrderedGems:
Enabled: true

Expand Down Expand Up @@ -42,3 +42,8 @@ Performance/Casecmp:
# See: https://github.com/rubocop/rubocop-performance/issues/329#issuecomment-1451511402
Performance/IoReadlines:
Enabled: false

# This cop is 66% incorrect, and hasn't been fixed in 2+ years.
# See: https://github.com/rubocop/rubocop-rake/issues/42
Rake/MethodDefinitionInTask:
Enabled: false

0 comments on commit 26ba5f8

Please sign in to comment.