Correctly remove the buildin rails adapter#23
Merged
michaelklishin merged 1 commit intoruby-amqp:mainfrom Nov 8, 2024
Merged
Conversation
`defined?` for a string literal is always truthy, same as for symbols.
`defined?(ActiveJob::QueueAdapters::SneakersAdapter)` would work as an alternative.
```rb
module ActiveJob
module QueueAdapters
# Adapter removed from rails
end
end
module ActiveJob
module QueueAdapters
remove_const(:SneakersAdapter) if defined?("::#{name}::SneakersAdapter")
end
end
```
test.rb:10:in `remove_const': constant ActiveJob::QueueAdapters::SneakersAdapter not defined (NameError)
Member
|
@Earlopain I assume we really need to produce a new patch release? I can do that today. |
Contributor
Author
|
Ah no, I don't think so. The adapter is still present in rails 8.0 so it is not urgent for a number of months yet. It isn't even deprecated yet (if they go with that route). |
Member
|
@Earlopain ah, OK. Thank you for the explanation. We certainly will ship a new patch release in the next few months. |
michaelklishin
pushed a commit
that referenced
this pull request
Nov 8, 2024
`defined?` for a string literal is always truthy, same as for symbols.
`defined?(ActiveJob::QueueAdapters::SneakersAdapter)` would work as an alternative.
```rb
module ActiveJob
module QueueAdapters
# Adapter removed from rails
end
end
module ActiveJob
module QueueAdapters
remove_const(:SneakersAdapter) if defined?("::#{name}::SneakersAdapter")
end
end
```
test.rb:10:in `remove_const': constant ActiveJob::QueueAdapters::SneakersAdapter not defined (NameError)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup #19. cc @dixpac
defined?for a string literal is always truthy, same as for symbols.defined?(ActiveJob::QueueAdapters::SneakersAdapter)would work as an alternative.test.rb:10:in 'remove_const': constant ActiveJob::QueueAdapters::SneakersAdapter not defined (NameError)