Relax ActiveJob version constraint #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialy gem checked for existance of active_job >=7.2, mainly because of `ActiveJob::QueueAdapters::AbstractAdapter`. But since that class is base adapter with conteact for `enqueue` and `enqueue_at` we don't have to inherit from it. This should allow other rails versions to work.
dixpac
changed the title
|
@dixpac good find! |
|
Thank you for contributing. I've set the milestone to |
michaelklishin
added a commit
that referenced
this pull request
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially gem checked for existence of active_job >=7.2, mainly because of
ActiveJob::QueueAdapters::AbstractAdapter.But since that class is base adapter with contract for
enqueueandenqueue_atwe don't have to inherit from it. This should allow other rails versions to work.