The extractAllScripts should default to false in flatten.

ruby-rdf · Jul 24, 2024 · 24a67f4 · 24a67f4
1 parent c5493c1
commit 24a67f4
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 4 deletions.
diff --git a/lib/json/ld/api.rb b/lib/json/ld/api.rb
@@ -290,8 +290,7 @@ def self.compact(input, context, expanded: false, serializer: nil, **options)
       def self.flatten(input, context, expanded: false, serializer: nil, **options)
         flattened = []
         options = {
-          compactToRelative: true,
-          extractAllScripts: true
+          compactToRelative: true
         }.merge(options)
 
         # Expand input to simplify processing
@@ -518,6 +517,8 @@ def self.frame(input, frame, expanded: false, serializer: nil, **options)
       # @option options (see #initialize)
       # @option options [Boolean] :produceGeneralizedRdf (false)
       #   If true, output will include statements having blank node predicates, otherwise they are dropped.
+      # @option options [Boolean] :extractAllScripts (true)
+      #   If set, when given an HTML input without a fragment identifier, extracts all `script` elements with type `application/ld+json` into an array during expansion.
       # @raise [JsonLdError]
       # @yield statement
       # @yieldparam [RDF::Statement] statement

diff --git a/spec/flatten_spec.rb b/spec/flatten_spec.rb
@@ -557,6 +557,37 @@
           "@graph": [{"@id": "_:b0","foo": ["bar"]}]
         })
       },
+      'Flattens first script element by default': {
+        input: %(
+        <html>
+          <head>
+            <script type="application/ld+json">
+            {
+              "@context": {
+                "foo": {"@id": "http://example.com/foo", "@container": "@list"}
+              },
+              "foo": [{"@value": "bar"}]
+            }
+            </script>
+            <script type="application/ld+json">
+            {
+              "@context": {"ex": "http://example.com/"},
+              "@graph": [
+                {"ex:foo": {"@value": "foo"}},
+                {"ex:bar": {"@value": "bar"}}
+              ]
+            }
+            </script>
+          </head>
+        </html>),
+        context: %({"foo": {"@id": "http://example.com/foo", "@container": "@list"}}),
+        output: %({
+          "@context": {
+            "foo": {"@id": "http://example.com/foo", "@container": "@list"}
+          },
+          "@graph": [{"@id": "_:b0","foo": ["bar"]}]
+        })
+      },
       'Flattens first script element with extractAllScripts: false': {
         input: %(
         <html>
@@ -622,7 +653,7 @@
         }),
         base: "http://example.org/doc#second"
       },
-      'Flattens all script elements by default': {
+      'Flattens all script elements extractAllScripts: true': {
         input: %(
         <html>
           <head>
@@ -656,7 +687,8 @@
             {"@id": "_:b1", "ex:foo": "foo"},
             {"@id": "_:b2", "ex:bar": "bar"}
           ]
-        })
+        }),
+        extractAllScripts: true
       }
     }.each do |title, params|
       it(title) do