Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement exit_program (!!!) command #825

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sambostock
Copy link

Pry includes an exit-program command, also aliased as quit-program and !!! which calls Kernel.exit. This is useful when binding.pry has been used in a loop.

This implements a similar exit_program command, also aliased as quit_program and !!!.

:irb_exit_program, :ExitProgram, 'cmd/exit_program',
[:exit_program, NO_OVERRIDE],
[:quit_program, NO_OVERRIDE],
[:'exit-program', NO_OVERRIDE], # FIXME: This doesn't work properly; seems to match normal "exit" command
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work, but maybe we don't care?

I'd added these to match the commands in Pry, but I see we use show_source rather than show-source, so maybe we only want exit_program and quit_program.

@sambostock sambostock force-pushed the exit-program branch 2 times, most recently from 330baa6 to 88d955d Compare December 25, 2023 18:02
@sambostock sambostock marked this pull request as ready for review December 25, 2023 18:08
Pry includes an `exit-program` command, also aliased as `quit-program`
and `!!!` which calls `Kernel.exit`. This is useful when `binding.pry`
has been used in a loop.

This implements a similar `exit_program` command, also aliased as
`quit_program` and `!!!`.
@st0012
Copy link
Member

st0012 commented Feb 12, 2024

With #851, the new exit! command is now essentially exit_program without taking an status argument. Do you want to rebase this PR and then introduce the !!! as an alias to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants