Skip to content

Add types to states#463

Merged
ydah merged 3 commits intoruby:masterfrom
Little-Rubyist:add_types_to_states
Jul 30, 2024
Merged

Add types to states#463
ydah merged 3 commits intoruby:masterfrom
Little-Rubyist:add_types_to_states

Conversation

@Little-Rubyist
Copy link
Contributor

This is the type definition of Item.rb added in this PR.

end

def symbols_before_dot
def symbols_before_dot # steep:ignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array#[] is nullable but symbols_before_dot and symbols_after_dot are not.
But I couldn't make Array#[] temporarily not null, so I added steep:ignore .

Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah ydah merged commit 755a547 into ruby:master Jul 30, 2024
@Little-Rubyist Little-Rubyist deleted the add_types_to_states branch July 30, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants