Skip to content

ssl: add SSLContext#sigalgs= and #client_sigalgs= #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025

Conversation

rhenium
Copy link
Member

@rhenium rhenium commented Jun 3, 2025

Add methods for setting supported signature algorithms, corresponding to SSL_CTX_set1_sigalgs_list() and SSL_CTX_set1_client_sigalgs_list(), respectively.

Supersedes #769
/cc @mj-vivavis

@junaruga
Copy link
Member

junaruga commented Jun 3, 2025

The CI failures are not related to this PR. I opened the issue ticket #897. The ruby/ruby removed Ractor#take.

junaruga added a commit to junaruga/ruby-openssl-pqc-test that referenced this pull request Jun 5, 2025
Note the following PR is needed to use the feature.
ruby/openssl#895
junaruga added a commit to junaruga/ruby-openssl-pqc-test that referenced this pull request Jun 5, 2025
Note the following PR is needed to use the feature.
ruby/openssl#895
Copy link
Member

@junaruga junaruga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed. Could you check my comments? Thank you!

@rhenium rhenium force-pushed the ky/ssl-sigalgs branch 2 times, most recently from 68c9b8f to d54774e Compare June 19, 2025 17:34
rhenium and others added 2 commits June 21, 2025 01:17
Add methods for setting supported signature algorithms, corresponding
to SSL_CTX_set1_sigalgs_list() and SSL_CTX_set1_client_sigalgs_list(),
respectively.

Co-authored-by: Markus Jung <[email protected]>
@junaruga
Copy link
Member

Now the PR looks good to me! Thank you for working on it!

@rhenium rhenium merged commit 328d0dc into ruby:master Jun 20, 2025
41 checks passed
@rhenium
Copy link
Member Author

rhenium commented Jun 20, 2025

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants