ssl: allow SSLContext#set_params to be used from non-main Ractors #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think these Windows jobs are failing due to https://bugs.ruby-lang.org/issues/21537. |
rhenium
force-pushed
the
ky/ssl-set-params-ractors
branch
from
c05b300 to
3f3c2e2
Compare
rhenium
force-pushed
the
ky/ssl-set-params-ractors
branch
from
3f3c2e2 to
7cc1374
Compare
Freeze OpenSSL::SSL::SSLContext::DEFAULT_PARAMS so that it becomes Ractor-shareable. Also, prepare a new OpenSSL::X509::Store in Ractor-local storage, if called from a non-main Ractor. OpenSSL::X509::Store currently is not a shareable object.
rhenium
force-pushed
the
ky/ssl-set-params-ractors
branch
from
7cc1374 to
3d52713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeze
OpenSSL::SSL::SSLContext::DEFAULT_PARAMSto make it Ractor-shareable.When called from a non-main Ractor,
SSLContext#set_paramsnow prepares a newOpenSSL::X509::Storein Ractor-local storage.This applies on top of #924. Fixes #521.
Note that you need https://bugs.ruby-lang.org/issues/21109 to use
SSLSocketin a non-main Ractor, which will be part of Ruby 3.5.