Fix test_pkcs12.rb in FIPS. #997
Draft
+161
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the `AES-256-CBC` using `PBKDF2` which is FIPS-approved, instead of the `PBE-SHA1-3DES` using `PKCS12KDF` which is not FIPS-approved. See also the man page openssl-pkcs12(1). * `OpenSSL::PKCS12.create` calling the `PKCS12_create` has the argument `mac_iter` which uses a MAC key using `PKCS12KDF` which is not FIPS-approved. In the FIPS case, set the `mac_iter = -1` to omit the MAC key. See also the man page PKCS12_create(3). * As the test data `OpenSSL::PKCS12.new` calling `PKCS12_parse` verifies the MAC using `PKCS12KDF` which is not FIPS-approved, I created the test data without MAC by the `openssl pkcs12 -nomac`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is working in progress.
I see the test failures on LibreSSL and AWS-LC cases.
AES-256-CBCusingPBKDF2which is FIPS-approved, instead of thePBE-SHA1-3DESusingPKCS12KDFwhich is not FIPS-approved. See also the man page openssl-pkcs12(1).OpenSSL::PKCS12.createcalling thePKCS12_createhas the argumentmac_iterwhich uses a MAC key usingPKCS12KDFwhich is not FIPS-approved. In the FIPS case, set themac_iter = -1to omit the MAC key. See also the man page PKCS12_create(3).OpenSSL::PKCS12.newcallingPKCS12_parseverifies the MAC usingPKCS12KDFwhich is not FIPS-approved, I created the test data without MAC by theopenssl pkcs12 -nomac.