Skip to content

Add a new workflow to deploy page preview for PRs from forks #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

st0012
Copy link
Member

@st0012 st0012 commented May 11, 2025

Closes #1356

The default cloudflare integration with GH doesn't deploy previews for forks as attackers may modify the workflow configs to collect api tokens....etc.

So I want to switch from CL's default integration to this new workflow instead:

  • For PRs opened from ruby/rdoc branches, the preview still be built automatically
  • For PRs opened from forks, their preview needs to be triggered manually by maintainers, after making sure that the content is not malicious
    • To manually build previews for a PR, the PR's number is a required input
    • On these PRs, another workflow will generate a comment that contains a link to trigger cloudflare-preview with the PR number

st0012 added 2 commits May 11, 2025 09:23
The comment should allow maintainers to trigger a preview deployment for
fork PRs more easily.
Copy link

cloudflare-workers-and-pages bot commented May 11, 2025

Deploying rdoc with  Cloudflare Pages  Cloudflare Pages

Latest commit: 27fff3d
Status: ✅  Deploy successful!
Preview URL: https://a3a675dd.rdoc-6cd.pages.dev
Branch Preview URL: https://support--1356.rdoc-6cd.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview feature is not working with forked repository
1 participant