fix: Page.frameStoppedLoading should not wait for document_node_id re…

…sponse
rubycdp · Aug 3, 2024 · 5ca5e9e · 5ca5e9e
1 parent 11ccf79
commit 5ca5e9e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@
 
 - `:ws_url` option is now used without modifications WYSIWYG.
 - `Network.requestWillBeSent` callback didn't handle params in a type-safe way
+- `Page.frameStoppedLoading` callback shouldn't wait for document_node_id response
 
 ### Removed
 

diff --git a/lib/ferrum/page.rb b/lib/ferrum/page.rb
@@ -391,7 +391,9 @@ def use_authorized_proxy?
       use_proxy? && @proxy_user && @proxy_password
     end
 
-    def document_node_id
+    def document_node_id(async: false)
+      return client.command("DOM.getDocument", async: true, depth: 0) if async
+
       command("DOM.getDocument", depth: 0).dig("root", "nodeId")
     end
 

diff --git a/lib/ferrum/page/frames.rb b/lib/ferrum/page/frames.rb
@@ -128,7 +128,7 @@ def subscribe_frame_stopped_loading
           # node will change the id and all subsequent nodes have to change id too.
           if @main_frame.id == params["frameId"]
             @event.set if idling?
-            document_node_id
+            document_node_id(async: true)
           end
 
           frame = @frames[params["frameId"]]