Skip to content

Fix reverse dependencies by using distinct #5566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −0
Open

Fix reverse dependencies by using distinct #5566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controllers/reverse_dependencies_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ def index
@reverse_dependencies = @rubygem.reverse_dependencies
.by_downloads
.preload(:gem_download, :latest_version)
.distinct
.select("rubygems.*, gem_downloads.count")

@reverse_dependencies = @reverse_dependencies.legacy_search(params[:rdeps_query]) if params[:rdeps_query].is_a?(String)
@reverse_dependencies = @reverse_dependencies.page(@page).without_count
Expand Down
16 changes: 16 additions & 0 deletions test/functional/reverse_dependencies_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class ReverseDependenciesControllerTest < ActionController::TestCase
@rubygem_three = @version_three.rubygem
@version_four = create(:version)
@rubygem_four = @version_four.rubygem
@version_two_two = create(:version, rubygem: @rubygem_two, position: 0)

@version_two.dependencies << create(:dependency,
version: @version_two,
Expand All @@ -21,6 +22,9 @@ class ReverseDependenciesControllerTest < ActionController::TestCase
@version_four.dependencies << create(:dependency,
version: @version_four,
rubygem: @rubygem_two)
@version_two_two.dependencies << create(:dependency,
version: @version_two_two,
rubygem: @rubygem_one)
end

context "render template" do
Expand All @@ -43,6 +47,18 @@ class ReverseDependenciesControllerTest < ActionController::TestCase
assert page.has_selector?("form#rdeps-search[action='#{form_path}']")
end

should "show distinct reverse dependencies" do
@version_two.update_column(:position, 0)
get :index, params: { rubygem_id: @rubygem_one.slug }

assert page.has_content?(@rubygem_two.name, count: 1)
refute page.has_content?(@rubygem_three.name)

form_path = rubygem_reverse_dependencies_path(@rubygem_one.slug)

assert page.has_selector?("form#rdeps-search[action='#{form_path}']")
end

should "search reverse dependencies" do
get :index,
params: {
Expand Down