-
-
Notifications
You must be signed in to change notification settings - Fork 974
Change logic displaying remove ownership button #5709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxSukhanov
wants to merge
25
commits into
rubygems:master
Choose a base branch
from
MaxSukhanov:MaxSukhanov/change-logic-displaying-remove-ownership-button
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
06ec3ca
Hide removal button for personal ownerships
MaxSukhanov 5b2e8f3
Ensure audit page is rendered before clicking.
simi 73515af
Bump pghero from 3.6.2 to 3.7.0 (#5698)
dependabot[bot] c63921f
Bump rubocop-minitest from 0.38.0 to 0.38.1 in the rubocop group (#5712)
dependabot[bot] 2b4f956
Bump ossf/scorecard-action from 2.4.1 to 2.4.2 (#5711)
dependabot[bot] ae9eff6
Bump csv from 3.3.4 to 3.3.5 (#5713)
dependabot[bot] af3e8ab
set GOOD_JOB_QUEUE_SELECT_LIMIT env var (#5715)
colby-swandale 4a31a03
notify users of new policy from last known good send (#5716)
colby-swandale de97ea0
Bump github/codeql-action from 3.28.18 to 3.28.19
dependabot[bot] dbfa01f
Bump groupdate from 6.6.0 to 6.7.0
dependabot[bot] 589e058
Bump datadog from 2.16.0 to 2.17.0 (#5719)
dependabot[bot] 528dfe8
Bump the aws group with 2 updates (#5718)
dependabot[bot] 3c12560
Bump rack from 3.1.15 to 3.1.16 (#5723)
dependabot[bot] 8602533
Bump rbtrace from 0.5.1 to 0.5.2 (#5725)
dependabot[bot] ec99331
Bump datadog-ci from 1.17.0 to 1.18.0 (#5724)
dependabot[bot] c670b4f
Bump aws-sdk-s3 from 1.189.0 to 1.189.1 in the aws group (#5728)
dependabot[bot] b41c3e7
remove email policy maintenance task (#5730)
colby-swandale 9646455
Bump ruby/setup-ruby from 1.244.0 to 1.245.0 (#5732)
dependabot[bot] 71b4947
Bump github/codeql-action from 3.28.19 to 3.29.0 (#5731)
dependabot[bot] bc87b17
Resolve FromAsCasing warnings
landongrindheim 0b6e979
Bump factory_bot_rails from 6.4.4 to 6.5.0 (#5734)
dependabot[bot] 57ce320
Update logic to allow removal of personal membership
MaxSukhanov 1ec6044
Merge branch 'master' into MaxSukhanov/change-logic-displaying-remove…
MaxSukhanov 57c0007
Merge branch 'master' into MaxSukhanov/change-logic-displaying-remove…
MaxSukhanov da3492f
Merge branch 'master' into MaxSukhanov/change-logic-displaying-remove…
MaxSukhanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though the delete action button has been disabled, i would still like to see a test, maybe just a unit/functional, that verifies that that we're not allowing this action to take place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colby-swandale I believe that there are two tests verifying this:
I updated the logic responsible for hiding the button according to the issue description.