Remove twitter social media bias

[nzukie-b]

Issue: #5511

Talked this over with @qrush and we decided to just remove twitter entirely.

[qrush]

Wanted to +1 this - talking this over at Railsconf, and the use of twitter_username here is so small, and the profiles page usage is also trivial compared to the gems view page - that it would be easier just to remove this feature entirely instead of creating a separate place where we expect developers to keep social media up to date. ✂️

This PR should close rubygems/rfcs#51 as well.

[simi]

This PR should close rubygems/rfcs#51 as well.

@qrush I don't think so. I don't think removing Twitter/X (without replacement) is good idea, I would rather replace it with more free-form link as described at rubygems/rfcs#51. The purpose of that RFC is not to remove social media links, but to extend them to not be bound to one platform.

[qrush]

@simi hi! I'd rather just not have rubygems.org worry about social media links in general, but if someone else wants to add socialize links - PRs are welcome! At the very least this PR removes twitter usernames but keeps the DB column, so it could be a future migration step. I don't think we will be missing anything huge or doing a disservice to our existing users by removing this very small link from profile pages.

[simi]

@qrush I'm often grateful for any possible contact to gem authors, to help them preserve the gem. So removal will make it much harder without replacement. Wouldn't be possible to at least rename the column to more generic one, migrate current values to Twitter/X url and leave anyone to decide what to put in there?

[segiddins]

User.group(:twitter_username).count.sort_by(&:last).reverse.first(5).to_h
=> {nil => 220926, "" => 6382, "opss_2020" => 296, "..." => 12, "..." => 6}
User.where("twitter_username is not null and twitter_username != ''").count
=> 7206

[qrush]

Thanks @segiddins - so that's 2.7% of users with this column set in a meaningful way. That doesn't seem like it provides a lot of value for contacting a user when you can rely on going to the gem's source / github to get more info.

This PR doesn't mean we can't migrate to something else later...but it does fix the bias towards just one social media site.

[simi]

@qrush if your goal is really to just remove Twitter from RubyGems.org, there's nothing more I can contribute in this discussion.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.42%. Comparing base (49d2ac1) to head (692745c).
Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
app/helpers/users_helper.rb	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5796      +/-   ##
==========================================
- Coverage   97.19%   94.42%   -2.77%     
==========================================
  Files         471      471              
  Lines        9690     9748      +58     
==========================================
- Hits         9418     9205     -213     
- Misses        272      543     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[simi]

Can you rename to social_link (and follow the same for helpers ...) and remove the forma_using here (swap with validation on model side to be valid link)?

[simi]

remove the icon here and just use the link in link_to as is in social_link field (if present)

[simi]

@qrush @segiddins @nzukie-b btw. I'm not blocking this, feel free to merge once you're happy. I can do the other part (transferring into generic social_link column) as follow-up.