Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/controllers/api/v1/owners_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ class Api::V1::OwnersController < Api::BaseController

def show
respond_to do |format|
format.json { render json: @rubygem.owners }
format.yaml { render yaml: @rubygem.owners }
format.json { render json: owners_payload }
format.yaml { render yaml: owners_payload }
end
end

Expand Down Expand Up @@ -83,4 +83,11 @@ def email_param
def ownership_params
params.permit(:role)
end

def owners_payload
@rubygem.owners
.joins(:ownerships)
.select("users.id, users.public_email, users.email, users.handle, users.webauthn_id, ownerships.role as role")
.map { |owner| owner.payload.merge("role" => Ownership.roles.key(owner.role)) }
end
end
15 changes: 15 additions & 0 deletions test/functional/api/v1/owners_controller_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,21 @@ def self.should_respond_to(format)
should respond_with :not_found
end

context "GET /api/v1/gems/:gem/owners.json" do
setup do
@user = create(:user, public_email: true)
@rubygem = create(:rubygem, owners: [@user])
get :show, params: { rubygem_id: @rubygem.slug }, format: :json
@user_payload = JSON.parse(@response.body).first
end
should "include associated users id, handle, email, and role in response" do
assert_equal "owner", @user_payload["role"]
assert_equal @user.id, @user_payload["id"]
assert_equal @user.handle, @user_payload["handle"]
assert_equal @user.email, @user_payload["email"]
end
end

should "route POST /api/v1/gems/rubygem/owners.json" do
route = { controller: "api/v1/owners",
action: "create",
Expand Down
Loading