-
Notifications
You must be signed in to change notification settings - Fork 285
Pass valid filenames to RuboCop and Reek #720
Conversation
Without extraneous single quotes. Closes rubyide#719.
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
======================================
Coverage 5.08% 5.08%
======================================
Files 10 10
Lines 118 118
Branches 20 20
======================================
Hits 6 6
Misses 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This PR has not had activity for 30 days. It will be automatically closed in 7 days. |
Please don't auto-close this PR. The issue is awaiting review. |
I've recently started developing in ruby and ran into this issue. @FooBarWidget Thank you for digging into this and submitting a fix! This PR has been open for a few months now, unfortunately it doesn't look like any of the current approvers have write access. Does someone with write access have time to take a look? Thanks! |
@wingrunr21 or @rebornix Can you review this please to unblock #227? |
This PR has not had activity for 30 days. It will be automatically closed in 7 days. |
It would really be great if someone could please review this. |
Thanks @wingrunr21 !!! Any ETA on a new release? |
I have to manually QA the extension and then I will cut a release. Won't be able to do that until after work tonight. |
You're a champion. Thank you again!
…On Mon, Sep 27, 2021 at 10:48 AM Stafford Brunk ***@***.***> wrote:
I have to manually QA the extension and then I will cut a release. Won't
be able to do that until after work tonight.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#720 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APRKQYWY43WJ7NVDVQA2KH3UECU7FANCNFSM4ZZLZ7OQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
I believe this PR also fixes #578. |
this is still happening now for me. |
Fixes bug #719.