Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Pass valid filenames to RuboCop and Reek #720

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

FooBarWidget
Copy link
Contributor

Fixes bug #719.

  • The build passes
  • TSLint is mostly happy — It was already unhappy. This PR doesn't make it more unhappy.
  • Prettier has been run — Not possible because TSLint was already unhappy through no fault of this PR.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #720 (18d5a00) into master (7b5b602) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #720   +/-   ##
======================================
  Coverage    5.08%   5.08%           
======================================
  Files          10      10           
  Lines         118     118           
  Branches       20      20           
======================================
  Hits            6       6           
  Misses        112     112           
Flag Coverage Δ
language_server_ruby 5.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5b602...18d5a00. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 6, 2021

This PR has not had activity for 30 days. It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label May 6, 2021
@FooBarWidget
Copy link
Contributor Author

Please don't auto-close this PR. The issue is awaiting review.

@wingrunr21 wingrunr21 added bug Bug reports and removed stale labels May 6, 2021
@royalpeasantry
Copy link

I've recently started developing in ruby and ran into this issue.

@FooBarWidget Thank you for digging into this and submitting a fix!

This PR has been open for a few months now, unfortunately it doesn't look like any of the current approvers have write access. Does someone with write access have time to take a look?

Thanks!

@ghost
Copy link

ghost commented Jul 16, 2021

@wingrunr21 or @rebornix Can you review this please to unblock #227?

@github-actions
Copy link

This PR has not had activity for 30 days. It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Sep 15, 2021
@sgray
Copy link

sgray commented Sep 15, 2021

It would really be great if someone could please review this.

@github-actions github-actions bot removed the stale label Sep 16, 2021
@wingrunr21 wingrunr21 merged commit 0b6cd1c into rubyide:main Sep 27, 2021
@ghost
Copy link

ghost commented Sep 27, 2021

Thanks @wingrunr21 !!! Any ETA on a new release?

@wingrunr21
Copy link
Collaborator

I have to manually QA the extension and then I will cut a release. Won't be able to do that until after work tonight.

@ghost
Copy link

ghost commented Sep 27, 2021 via email

@benzado
Copy link

benzado commented Apr 20, 2022

I believe this PR also fixes #578.

@robertwt7
Copy link

this is still happening now for me. forceExclusion doesn't seem to be a valid option anymore in settings.json

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants