Add MiniRacer::Platform.set_flags! for the truffleruby backend #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI is green, except |
bnoordhuis
approved these changes
Jan 7, 2025
Collaborator
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
I don't know if it is going to be enough to turn CI for #325 green but it's an improvement regardless. LGTM!
eregon
added a commit
to eregon/mini_racer
that referenced
this pull request
Jan 8, 2025
rubyjs#326)" * This reverts commit a268a2c. * Now it's defined in "shared" code like before.
eregon
added a commit
to eregon/mini_racer
that referenced
this pull request
Jan 9, 2025
rubyjs#326)" * This reverts commit a268a2c. * Now it's defined in "shared" code like before.
SamSaffron
added a commit
that referenced
this pull request
Jan 9, 2025
* Cleanup code in lib/mini_racer.rb and remove tabs * Fix the truffleruby backend by restoring the logic which used to be shared in lib/mini_racer.rb * See #325 * I copied lib/mini_racer.rb from a268a2c (just before that PR) and removed the duplicated definitions with what's left on master in lib/mini_racer.rb. * This brings it down to `5 failures, 6 errors` vs `10 failures, 60 errors` before. * Revert "Add MiniRacer::Platform.set_flags! for the truffleruby backend (#326)" * This reverts commit a268a2c. * Now it's defined in "shared" code like before. * Move #low_memory_notification and #idle_notification from Isolate to Context * Adjust to MiniRacer::SnapshotError#initialize changes * Support overwriting for #attach for the new #test_attach_non_object test * Pass MiniRacerTest#test_estimated_size_when_disposed on truffleruby * Skip a failing test which seems hard to fix * Convert JS Map to Ruby Hash and handle Map Iterator * Also improve test for clarity. * Exclude CRuby-only test * Tweak #test_symbol_support to allow the original behavior * Until the desired behavior is clarified. * Extend #test_map and fix behavior for the Map#values() case * Update test/mini_racer_test.rb Co-authored-by: Ben Noordhuis <[email protected]> --------- Co-authored-by: Sam <[email protected]> Co-authored-by: Ben Noordhuis <[email protected]>
bnoordhuis
pushed a commit
to bnoordhuis/mini_racer
that referenced
this pull request
Mar 13, 2025
…s#326) Add MiniRacer::Platform.set_flags! for the truffleruby backend. Remove macos-12 image from CI. No longer exists on GitHub.
bnoordhuis
added a commit
to bnoordhuis/mini_racer
that referenced
this pull request
Mar 13, 2025
* Cleanup code in lib/mini_racer.rb and remove tabs * Fix the truffleruby backend by restoring the logic which used to be shared in lib/mini_racer.rb * See rubyjs#325 * I copied lib/mini_racer.rb from a268a2c (just before that PR) and removed the duplicated definitions with what's left on master in lib/mini_racer.rb. * This brings it down to `5 failures, 6 errors` vs `10 failures, 60 errors` before. * Revert "Add MiniRacer::Platform.set_flags! for the truffleruby backend (rubyjs#326)" * This reverts commit a268a2c. * Now it's defined in "shared" code like before. * Move #low_memory_notification and #idle_notification from Isolate to Context * Adjust to MiniRacer::SnapshotError#initialize changes * Support overwriting for #attach for the new #test_attach_non_object test * Pass MiniRacerTest#test_estimated_size_when_disposed on truffleruby * Skip a failing test which seems hard to fix * Convert JS Map to Ruby Hash and handle Map Iterator * Also improve test for clarity. * Exclude CRuby-only test * Tweak #test_symbol_support to allow the original behavior * Until the desired behavior is clarified. * Extend #test_map and fix behavior for the Map#values() case * Update test/mini_racer_test.rb Co-authored-by: Ben Noordhuis <[email protected]> --------- Co-authored-by: Sam <[email protected]> Co-authored-by: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.