Fix TruffleRuby backend after #325 #328
Conversation
| MARSHAL_STACKDEPTH_DEFAULT = 2**9-2 | ||
| MARSHAL_STACKDEPTH_MAX_VALUE = 2**10-2 |
There was a problem hiding this comment.
FWIW, these are gone; the C code accepts marshal_stack_depth but otherwise ignores it.
| @eval_thread = nil | ||
|
|
||
| # defined in the C class | ||
| init_unsafe(isolate, snapshot) |
There was a problem hiding this comment.
init_unsafe no longer exists
There was a problem hiding this comment.
It does, it's defined in lib/mini_racer/truffleruby.rb.
| def isolate | ||
| return @isolate if @isolate != false | ||
| # defined in the C class | ||
| @isolate = create_isolate_value | ||
| end |
There was a problem hiding this comment.
Isolates no longer exist (or rather, are not exposed in the Ruby API)
There was a problem hiding this comment.
Right, I took a quick look but it's not so easy to remove so that could be done separately and I think best to get the CI green first (e.g. to avoid regressions).
There was a problem hiding this comment.
Isolates no longer exist (or rather, are not exposed in the Ruby API)
I only followed the recent changes partially, but why has the Isolates API been removed? I have never used them but they have a big section in the README (https://github.com/rubyjs/mini_racer#shared-isolates). If they are gone for good, the README needs to be cleaned up to and it's a big fat breaking change too, but not mentioned in the CHANGELOG for yesterdays 0.17.0.pre6.
There was a problem hiding this comment.
README update in #331. The changelog was Sam's work, I think?
…hared in lib/mini_racer.rb * See rubyjs#325 * I copied lib/mini_racer.rb from a268a2c (just before that PR) and removed the duplicated definitions with what's left on master in lib/mini_racer.rb. * This brings it down to `5 failures, 6 errors` vs `10 failures, 60 errors` before.
rubyjs#326)" * This reverts commit a268a2c. * Now it's defined in "shared" code like before.
* Also improve test for clarity.
* Until the desired behavior is clarified.
eregon
force-pushed
the
fix-truffleruby-after-pr-325
branch
from
9e9ec35 to
ab4c4f5
Compare
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
I'm probably not the most qualified person to review but LGTM at a quick glance. Thanks for doing this, @eregon.
Co-authored-by: Ben Noordhuis <[email protected]>
|
thank you so much @eregon for the push here, I know how much extra work out of nowhere there was but our upgrade of our v8 integration was critical for the long term survival of MiniRacer, so happy to bring back full support |
* Cleanup code in lib/mini_racer.rb and remove tabs * Fix the truffleruby backend by restoring the logic which used to be shared in lib/mini_racer.rb * See rubyjs#325 * I copied lib/mini_racer.rb from a268a2c (just before that PR) and removed the duplicated definitions with what's left on master in lib/mini_racer.rb. * This brings it down to `5 failures, 6 errors` vs `10 failures, 60 errors` before. * Revert "Add MiniRacer::Platform.set_flags! for the truffleruby backend (rubyjs#326)" * This reverts commit a268a2c. * Now it's defined in "shared" code like before. * Move #low_memory_notification and #idle_notification from Isolate to Context * Adjust to MiniRacer::SnapshotError#initialize changes * Support overwriting for #attach for the new #test_attach_non_object test * Pass MiniRacerTest#test_estimated_size_when_disposed on truffleruby * Skip a failing test which seems hard to fix * Convert JS Map to Ruby Hash and handle Map Iterator * Also improve test for clarity. * Exclude CRuby-only test * Tweak #test_symbol_support to allow the original behavior * Until the desired behavior is clarified. * Extend #test_map and fix behavior for the Map#values() case * Update test/mini_racer_test.rb Co-authored-by: Ben Noordhuis <[email protected]> --------- Co-authored-by: Sam <[email protected]> Co-authored-by: Ben Noordhuis <[email protected]>
4 participants
See #325 (comment) and after for context.
All tests pass now, so this should fix the CI.