Handle two-byte string alignment padding #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with old clients of the serializer wire format, V8 inserts a padding byte when a two-byte string is not 16 bits aligned, so skip those. We don't have to emit padding ourselves, V8 handles unaligned strings just fine. Messages can have an arbitrary amount of padding at the end. Skip that as well. No test because hitting the right conditions in V8 is rather difficult and brittle.
bnoordhuis
added a commit
to bnoordhuis/mini_racer
that referenced
this pull request
Mar 13, 2025
For compatibility with old clients of the serializer wire format, V8 inserts a padding byte when a two-byte string is not 16 bits aligned, so skip those. We don't have to emit padding ourselves, V8 handles unaligned strings just fine. Messages can have an arbitrary amount of padding at the end. Skip that as well. No test because hitting the right conditions in V8 is rather difficult and brittle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with old clients of the serializer wire format, V8 inserts a padding byte when a two-byte string is not 16 bits aligned, so skip those.
We don't have to emit padding ourselves, V8 handles unaligned strings just fine.
Messages can have an arbitrary amount of padding at the end. Skip that as well.
No test because hitting the right conditions in V8 is rather difficult and brittle.