Convert deserialized strings to UTF-8 #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
commented
Jan 11, 2025
| assert_equal Encoding::UTF_8, context.eval("'ok\\uD800\\uDC00'").encoding | ||
| if RUBY_ENGINE != "truffleruby" | ||
| # unmatched surrogate pair, cannot be converted by ruby | ||
| assert_equal Encoding::UTF_16LE, context.eval("'ok\\uD800'").encoding |
Collaborator
Author
There was a problem hiding this comment.
@SamSaffron the alternative is to let the exception that ruby raises bubble up
Collaborator
There was a problem hiding this comment.
Yeah not sure if there is an easy way of winning here, lets try this out first.
SamSaffron
approved these changes
Jan 13, 2025
bnoordhuis
added a commit
to bnoordhuis/mini_racer
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.