Fix one-byte string Latin-1 to UTF-8 conversion #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby is not wrong to insist that an ASCII-8BIT string with a character that has its high bit set cannot be converted to UTF-8. Interpret such strings as ISO-8859-1 a.k.a. Latin-1 and only then convert to UTF-8.
SamSaffron
approved these changes
Jan 20, 2025
bnoordhuis
added a commit
to bnoordhuis/mini_racer
that referenced
this pull request
Mar 13, 2025
Ruby is not wrong to insist that an ASCII-8BIT string with a character that has its high bit set cannot be converted to UTF-8. Interpret such strings as ISO-8859-1 a.k.a. Latin-1 and only then convert to UTF-8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby is not wrong to insist that an ASCII-8BIT string with a character that has its high bit set cannot be converted to UTF-8. Interpret such strings as ISO-8859-1 a.k.a. Latin-1 and only then convert to UTF-8.