Handle termination exceptions during serialization #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't abort when the ruby thread calls `context.stop` right when the V8 thread is serializing its response to a request. Temporarily cancel the termination exception, retry serialization, and reraise the exception.
Collaborator
Author
|
The musl failures are partially the old "libv8-node not found" build errors but also partially this one that I hadn't seen before: Not caused by this PR, at least. |
Virtually the same `source_location` NoMethodError that's the reason for skipping test_date_nan.
SamSaffron
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't abort when the ruby thread calls
context.stopright when the V8 thread is serializing its response to a request. Temporarily cancel the termination exception, retry serialization, and reraise the exception.